-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load a config to customize output #2
base: master
Are you sure you want to change the base?
Conversation
Hi there, and thank you for contributing! I'd prefer if the absence of a config file would trigger the default behavior, but otherwise I think that's a great idea. This is my first PR on here so I'm not too sure how I could propose changes inside this PR; I'll look into that as soon as possible. |
Hi, |
Actually I really like the idea of the configuration file as you've done it. The only thing I would change is that I would look for a That way, current users would not have to worry about a new file and power users such as yourself could use a configuration file to produce this different output. |
Ah, I did not read your 1st response carefully enough :-) |
IMHO it should simply be in the current working directory, which would typically be the root of whatever project the user's in. (This is how other JS tools like |
a little update:
|
I like your improvements. 👍 I see you updated formatting a bit. I just realized this project didn't include my Is this your final version? If so I'll download/test it and merge by tomorrow so it can go out on NPM. |
Yep, I would like to leave it for the moment. If you agree the list of the checked custom config files. My nodejs experience is close to zero - please run the checks regarding code formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the motivation behind commit cli: do not write file if there is no change
? It might affect certain workflows if the target file is not modified or at least touched to reflect that it's up to date vs its source material. I don't think it's a big deal but I'd like to understand it better.
In my project documentations I describe installation, usage and "not all" markdowns contain a block for replacements for docblox2md. If I want to be lazy and execute it with *.md to loop over all files it is not needed to write files that I think it is an expected behaviour that if there is no change in a file then do not overwrite it with the former content. |
I see, yes. I had not thought about the The use case I was thinking of was a build tool like GNU Make with explicit rules (i.e. |
like in filterDocument() ... it needs a small method similiar to |
I added |
Thank you. I think that takes care of every use case. I'll merge this soon. 😃 |
Hi Stéphane
I was on search for generation of markdown for class files (an html help from it I will generate with Daux.io). I also liked the idea to add the output between 2 markers of an existing file.
Because the markdown output was hartcoded I put it into an extra file.
To be customized I added a dist file that overrides the default config.
Regards,
Axel